@MichaelKjörling in here when you've got time

room topic changed to Discussion of 'Flagging a deleted post should not give “you don't have permission”': meta.stackexchange.com/questions/233560/… [bug]

you might have to ping me back - I may not see you enter the room if you don't

@BenCollins Ding dong.

@BenCollins Doing ding.

hey there...so sorry. in a meeting, will be with you in a bit

Why are SE people always in meetings?

Why is there a file upload thing on the side here?

I wonder where the files go.

Oh dear.

ok, back

Hi!

@bjb568 so you folks can post screenshots if needs be :-)

@MichaelKjörling I'm back.

@BenCollins Why isn't it in the bottom strip?

@bjb568 I can't say for sure, but my guess would be that it wouldn't fit when using a narrow window for chat (as I do)

Uploaded:

It's like that in the tavern…

I dunno

would have to ask someone who knows more about chat than I do

@bjb568 so did you have anything to add about the post?

@BenCollins I'm back as well, for a few minutes; are you still back?

yep

I think the easiest way to test that specific behavior is to have a site where I don't have rep to see deleted posts; perhaps you create one, I load it and open the flag dialog, then you delete it, then I flag. And we see what comes out.

@bjb568 that doesn't make any sense to me, probably because I dont' know what comes before the ...

@BenCollins The original post.

I can't create that situation on my own, I don't have any officially sanctioned sock (and if I had one that wasn't officially sanctioned, I wouldn't tell you in public anyway ;))

Flagging a deleted post should not give “you don't have permission”, it should reload the page.

@bjb568 that is not going to happen

@BenCollins Why?

@bjb568 I'd rather it says outright that the post has already been deleted, actually. Make it obvious. But anything is better than an error that makes users think their ability to flag has been revoked :)

It could reload and show a message…

I'd like to go to bed, can we just test whether the error exists and then there can be a separate discussion about exactly how to handle the situation instead?

@MichaelKjörling yes, lets. sorry

pick a site and we can try it out

It's 22:18 where I am, and I have to work tomorrow :)

MSE?

@BenCollins How is it different from the reloading when the final spam flag or final close vote is cast?

@MichaelKjörling ok. you don't have rep to see deleted posts there?

@bjb568 no reload happens there

Nope. 1558 atm.

ok. lemme find a post

@BenCollins Wut? I'll show you…

I believe see deleted is 10k there. Part of access to moderator tools.

I'm pretty sure the only sites I can see deleted posts on are Worldbuilding (mod), Amateur Radio (mod) and Super User (10k+).

@MichaelKjörling how about this one?

meta.stackexchange.com/questions/125761/…

i'll undelete, you load, and then I'll delete again

@BenCollins Page not found.

ready?

Ready.

OK

go

got it?

Haha, I beat you to it. Even opened the flag dialog.

hold on

k, it's deleted again

now do the flag

Flagging for diamond attention now.

"Thanks, we'll take a look at it."

@MichaelKjörling yeah... that's what I saw when I tried to repro as well

And if I reopen the flag dialog diamond attention is the only option I have; no off topic, unclear, etc.

Maybe I should have picked some other flag reason?

(non-custom)

Can we try that too with another question?

let's keep using this one, I'll dismiss the flag

Okay.

reload now

Reloaded. About to flag.

Ready to flag.

ok, now try

Flagging

"You don't have permission to use this type of flag" (VLQ)

VLQ...ok, hold on

So it's something most likely related to non-customized flags. Which I guess makes sense, since even if a post has been deleted you can always flag for diamond moderator attention with a custom flag message, as long as you can see the post and its flag link in the first place.

It still deserves a better error message IMO :)

@BenCollins Do you think you have what you need for the moment? I'd like to go to bed. :-)

@MichaelKjörling I hope so. I'll look a bit more and ping you again if I need to

but not for at least 12 hours ;-)

@BenCollins :) I'll probably be around a computer from 08ish UTC. Either that, or shoot me an email (just poke at my profile for that).

kk

Bye for now.

Uploaded: Untitled.mov

@BenCollins ^

hm, so it does. probably because it has to rebake the content for the close notice at the bottom. Either way - not doing that here.

the fix is a correct error message, not to completely change what gets rendered and how

Ok, fine. Correct error message is good.

cool.