« first day (383 days earlier)      last day (1735 days later) » 

5:15 PM
@Taryn I've posted an answer here to fix BadgeiconUrl and Longname . It is ready to run to the best of my knowledge. Maybe to fill time for when you have to wait for an upgrade of SQL server to finish ;)
 
 
2 hours later…
7:36 PM
added the other Icon locations as well as those were broken on the query view
 
8:22 PM
@Taryn for that change you did here was the TinyName changed to get that <site>me format?
 
@rene yes, that uses TinyName
 
we don't have much options: GetSite is called to determine the correct site: github.com/StackExchange/StackExchange.DataExplorer/blob/master/… and that relies on either name or tinyname
if we really want to fix that specific use case we would need to allow to have the databasename be used in the url as well.
That needs a code change first
 
I fixed it because if we ever needed to rebuild the Sites table it would all move to <site>me
So really it's things break now or possibly later, in the event that needed to be recreated
 
we might get away with a rewrite rule in iis ...
@Taryn that is a valid reason
 
Unfortunately I don't know when the script changed that moved stuff from meta. to <site>me - we have far too many things in both right now and we should be in a state where all the data could be easily recreated and not break stuff
 
8:31 PM
agreed
what about having a fix in the code that "knows" about the meta. format? So I will create a PR that adds in GetSite some logic to check if sitename.StartsWith("meta.") and then do a sitename.Replace("meta.","") + "me" ?
then you can use the <site>me format and existing urls will still work.
Or we adapt the sql query that used there a bit with that logic
 
Just hold off and I'll chat with Nick when he is back next week about it. There are a few other things I need to talk to him about before fixing anyway
 
Okay, let me know if there is something I can assist with
If only for breaking things testing
 
haha will do
 
;)
 

« first day (383 days earlier)      last day (1735 days later) »